[webkit-reviews] review granted: [Bug 207467] Support in-band VTT captions when loading media in the GPU Process : [Attachment 390273] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 207467: Support in-band VTT captions when loading media in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=207467

Attachment 390273: Patch

https://bugs.webkit.org/attachment.cgi?id=390273&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 390273
  --> https://bugs.webkit.org/attachment.cgi?id=390273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390273&action=review

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:60
> +    ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data)
> +    ## AddDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data, String type)
> +    ## UpdateDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data)
> +    ## RemoveDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data)
> +
> +    ## AddGenericCue(WebCore::GenericCueData cue)
> +    ## UpdateGenericCue(WebCore::GenericCueData cue)
> +    ## RemoveGenericCue(WebCore::GenericCueData cue)

Are these supposed to be left in?

> Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.messages.in:40
> +    ## AddDataCue(MediaTime start, MediaTime end, IPC::DataReference data)
> +    ## AddDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data, String type)
> +    ## UpdateDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data)
> +    ## RemoveDataCue(MediaTime start, MediaTime end,
WebCore::SerializedPlatformRepresentation data)
> +
> +    ## AddGenericCue(WebCore::GenericCueData cue)
> +    ## UpdateGenericCue(WebCore::GenericCueData cue)
> +    ## RemoveGenericCue(WebCore::GenericCueData cue)

Ditto.