[webkit-reviews] review denied: [Bug 206248] [WebAuthn] Move the async code from WebAuthenticationPanelClient to AuthenticatorManager : [Attachment 390156] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 206248: [WebAuthn] Move the async code from WebAuthenticationPanelClient to
AuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=206248

Attachment 390156: Patch

https://bugs.webkit.org/attachment.cgi?id=390156&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 390156
  --> https://bugs.webkit.org/attachment.cgi?id=390156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390156&action=review

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:281
> +    dispatchPanelClientCall([retries, completionHandler =
WTFMove(completionHandler)] (const API::WebAuthenticationPanel& panel) mutable
{

If m_pendingRequestData.panel.get() returns null, this CompletionHandler will
not be called.	That's a problem that will cause hangs.

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:289
> +    responseVector.reserveCapacity(responses.size());

reserveInitialCapacity