[webkit-reviews] review granted: [Bug 207459] [watchOS] Notification listener is never unregistered : [Attachment 390250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 11:14:22 PST 2020


Maciej Stachowiak <mjs at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 207459: [watchOS] Notification listener is never unregistered
https://bugs.webkit.org/show_bug.cgi?id=207459

Attachment 390250: Patch

https://bugs.webkit.org/attachment.cgi?id=390250&action=review




--- Comment #3 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 390250
  --> https://bugs.webkit.org/attachment.cgi?id=390250
Patch

Maybe worth making an API test in case they are run there some day, or in case
we make this mistake on another platform?

Code change looks fine but I suggest adding a test.


More information about the webkit-reviews mailing list