[webkit-reviews] review granted: [Bug 207484] arm64_32: microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out : [Attachment 390268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 11:10:50 PST 2020


Yusuke Suzuki <ysuzuki at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 207484: arm64_32:
microbenchmarks/delete-property-keeps-cacheable-structure.js is timing out
https://bugs.webkit.org/show_bug.cgi?id=207484

Attachment 390268: Patch

https://bugs.webkit.org/attachment.cgi?id=390268&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 390268
  --> https://bugs.webkit.org/attachment.cgi?id=390268
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390268&action=review

r=me

> JSTests/microbenchmarks/delete-property-keeps-cacheable-structure.js:1
> +//@ skip if $architecture == "arm64_32" or $architecture == "arm7k"

Should we use something like, `$model =~ /^Apple Watch/` etc.? But I don't have
strong preference.


More information about the webkit-reviews mailing list