[webkit-reviews] review granted: [Bug 207099] [LFC][Integration] Support intruding floats : [Attachment 390217] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 207099: [LFC][Integration] Support intruding floats
https://bugs.webkit.org/show_bug.cgi?id=207099

Attachment 390217: patch

https://bugs.webkit.org/attachment.cgi?id=390217&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 390217
  --> https://bugs.webkit.org/attachment.cgi?id=390217
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390217&action=review

> Source/WebCore/layout/floats/FloatingState.cpp:51
> +FloatingState::FloatItem::FloatItem(Position position, Display::Box
absoluteDisplayBox)
> +    : m_position(position)
> +    , m_absoluteDisplayBox(absoluteDisplayBox)

At some point this needs to be expanded to cover isDescendantOfFormattingRoot()
as well (with the current integration setup/content, we don't call it).