[webkit-reviews] review canceled: [Bug 204457] Math.max() can yield the wrong result for max(0, -0). : [Attachment 390207] Consider negative zero in DFG JIT Math.{max, min}

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has canceled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 204457: Math.max() can yield the wrong result for max(0, -0).
https://bugs.webkit.org/show_bug.cgi?id=204457

Attachment 390207: Consider negative zero in DFG JIT Math.{max,min}

https://bugs.webkit.org/attachment.cgi?id=390207&action=review




--- Comment #6 from Xan Lopez <xan.lopez at gmail.com> ---
Comment on attachment 390207
  --> https://bugs.webkit.org/attachment.cgi?id=390207
Consider negative zero in DFG JIT Math.{max,min}

This test is already showing the bug in FTL I mentioned earlier (with the eager
run), and a fail in the DFG with --validateGraph. I'll have a look at both.