[webkit-reviews] review denied: [Bug 207352] Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes. : [Attachment 390052] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 207352: Add a variant of -[WKWebViewPrivate
_getContentsAsStringWithCompletionHandler:] that includes contents from
subframes.
https://bugs.webkit.org/show_bug.cgi?id=207352

Attachment 390052: Patch

https://bugs.webkit.org/attachment.cgi?id=390052&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 390052
  --> https://bugs.webkit.org/attachment.cgi?id=390052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390052&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:1081
>      void getContentsAsString(WTF::Function<void (const String&,
CallbackBase::Error)>&&);
> +    void getContentsAsStringInAllFrames(WTF::Function<void(const String&,
CallbackBase::Error)>&&);

Instead of making a new function doing basically the same thing, could you pass
a parameter?
enum class InAllFrames : bool { No, Yes };