[webkit-reviews] review granted: [Bug 207387] [ews] add commit-queue build step to close the bug : [Attachment 390088] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 7 09:51:59 PST 2020


Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 207387: [ews] add commit-queue build step to close the bug
https://bugs.webkit.org/show_bug.cgi?id=207387

Attachment 390088: Patch

https://bugs.webkit.org/attachment.cgi?id=390088&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 390088
  --> https://bugs.webkit.org/attachment.cgi?id=390088
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390088&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:562
> +	       self._addToLog('stdio', 'bug_id build property not found.\n')

Seems like we're duplicating this one a lot. Maybe add a 'has_bug_id' step to
BugzillaMixin in a separate patch?


More information about the webkit-reviews mailing list