[webkit-reviews] review granted: [Bug 206536] [ews] add commit-queue build step to clear flags on patch : [Attachment 390079] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 206536: [ews] add commit-queue build step to clear flags on patch
https://bugs.webkit.org/show_bug.cgi?id=206536

Attachment 390079: Patch

https://bugs.webkit.org/attachment.cgi?id=390079&action=review




--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 390079
  --> https://bugs.webkit.org/attachment.cgi?id=390079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390079&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:534
> +	   rc = self.remove_flags_on_patch(patch_id)

Nit: not sure rc is actually helpful here, I'd probably just put this call
inside self.finished. I don't feel particularly strongly about this, though.