[webkit-reviews] review granted: [Bug 207186] Adopt new SOAuthorizationOption constants : [Attachment 389634] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 17:31:11 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 207186: Adopt new SOAuthorizationOption constants
https://bugs.webkit.org/show_bug.cgi?id=207186

Attachment 389634: Patch

https://bugs.webkit.org/attachment.cgi?id=389634&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 389634
  --> https://bugs.webkit.org/attachment.cgi?id=389634
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389634&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:-172
> -    // FIXME: <rdar://problem/48909336> Replace the below with AppSSO
constants.

At last!


More information about the webkit-reviews mailing list