[webkit-reviews] review granted: [Bug 207341] [WK2][iOS] Add WKWebviewConfiguration SPI to run client navigations at foreground priority, even if the view is background : [Attachment 389981] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 207341: [WK2][iOS] Add WKWebviewConfiguration SPI to run client navigations
at foreground priority, even if the view is background
https://bugs.webkit.org/show_bug.cgi?id=207341

Attachment 389981: Patch

https://bugs.webkit.org/attachment.cgi?id=389981&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 389981
  --> https://bugs.webkit.org/attachment.cgi?id=389981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389981&action=review

r=me

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:153
> +    bool isViewService =
WTF::processHasEntitlement("com.apple.UIKit.vends-view-services") &&
[[m_webView window] _isHostedInAnotherProcess];
> +    if (_UIApplicationIsExtension() || isViewService) {

Might be nicer to use applicationType() here.