[webkit-reviews] review granted: [Bug 207351] Cleanup and promote WKContentWorld and its clients in WKWebView : [Attachment 389993] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 207351: Cleanup and promote WKContentWorld and its clients in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=207351

Attachment 389993: Patch

https://bugs.webkit.org/attachment.cgi?id=389993&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 389993
  --> https://bugs.webkit.org/attachment.cgi?id=389993
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389993&action=review

> Source/WebKit/Shared/Cocoa/APIObject.mm:-351
> -	   wrapper = [_WKContentWorld alloc];

There were no clients of this old class, right?  Otherwise we would need a
wrapper to keep binary compatibility.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:828
> +- (void)callAsyncJavaScript:(NSString *)javaScriptString
arguments:(NSDictionary<NSString *, id> *)arguments
inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^)(id,
NSError *error))completionHandler

The JavaScript is not necessarily Async.  Could we remove that?
If not, do we want to write out Asynchronous?