[webkit-reviews] review granted: [Bug 207319] Draw underlines when specified in highlights : [Attachment 389939] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 207319: Draw underlines when specified in highlights
https://bugs.webkit.org/show_bug.cgi?id=207319

Attachment 389939: Patch

https://bugs.webkit.org/attachment.cgi?id=389939&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 389939
  --> https://bugs.webkit.org/attachment.cgi?id=389939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389939&action=review

>
LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.
html:11
> +    O<span id="style1">n</span>e t<span id="style1">w</span>o th<span
id="style1">ree</span>

Use class not id (and change the selector above to .style1. Also make the text
bigger so that failures are more obvious (more pixels).

> LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations.html:13
> +	   <style>
> +	   ::highlight(example-highlight1) {
> +	       text-decoration: underline;
> +	   }
> +	   </style>

Extra indent here.