[webkit-reviews] review granted: [Bug 207248] [Web Inspector][WinCairo] Selecting an error message in Console causes "TypeError:​ selection.focusNode.closest is not a function." : [Attachment 389941] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 09:24:24 PST 2020


Devin Rousso <drousso at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 207248: [Web Inspector][WinCairo] Selecting an error message in Console
causes "TypeError:​ selection.focusNode.closest is not a function."
https://bugs.webkit.org/show_bug.cgi?id=207248

Attachment 389941: Patch

https://bugs.webkit.org/attachment.cgi?id=389941&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 389941
  --> https://bugs.webkit.org/attachment.cgi?id=389941
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389941&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:552
> +		   var focusElement = selection.focusNode;

Style: we prefer using `let`


More information about the webkit-reviews mailing list