[webkit-reviews] review granted: [Bug 207332] Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers list : [Attachment 389956] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 08:04:23 PST 2020


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 207332: Filter out TURN/STUN .local URLs from a RTCPeerConnection
iceServers list
https://bugs.webkit.org/show_bug.cgi?id=207332

Attachment 389956: Patch

https://bugs.webkit.org/attachment.cgi?id=389956&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 389956
  --> https://bugs.webkit.org/attachment.cgi?id=389956
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389956&action=review

> Source/WebCore/ChangeLog:8
> +	   Filter out TURN/STUN .local URLs from a RTCPeerConnection iceServers
list
> +	   https://bugs.webkit.org/show_bug.cgi?id=207332
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: webrtc/stun-server-filtering.html

It would be nice to have a comment explaining why this change is necessary.


More information about the webkit-reviews mailing list