[webkit-reviews] review denied: [Bug 138792] [GStreamer] Timeline scrubber not updating as the video plays : [Attachment 389800] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 138792: [GStreamer] Timeline scrubber not updating as the video plays
https://bugs.webkit.org/show_bug.cgi?id=138792

Attachment 389800: Patch

https://bugs.webkit.org/attachment.cgi?id=389800&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 389800
  --> https://bugs.webkit.org/attachment.cgi?id=389800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389800&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:408
> +	   this.controls.panel.classList.remove(this.ClassNames.hidden);

Always remove hidden before adding show.

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1027
> +	   this.controls.panel.classList.remove(this.ClassNames.hidden);

Always remove hidden before adding show.

> Source/WebCore/Modules/mediacontrols/mediaControlsBase.js:1035
> +	   this.controls.panel.classList.add(this.ClassNames.hidden);

When you do this, you remove the fade out animation of the controls. With this
they disappear immediately. The idea here is to remove the show and once the
fade out animation is done, we add the hidden in handlePanelTransitionEnd.
Could your problem be that handlePanelTransitionEnd is not being called for
some reason?

You can try any HTML5 pure video and you'll notice the difference.