[webkit-reviews] review denied: [Bug 197684] [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData : [Attachment 389719] patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 197684: [Win] Implement NetworkCache::Data by using
FileSystem::MappedFileData
https://bugs.webkit.org/show_bug.cgi?id=197684

Attachment 389719: patch

https://bugs.webkit.org/attachment.cgi?id=389719&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 389719
  --> https://bugs.webkit.org/attachment.cgi?id=389719
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389719&action=review

> Source/WTF/wtf/FileSystem.cpp:336
> +    default:
> +	   ASSERT_NOT_REACHED();

Could we remove the default and put EventsOnly?

> Source/WTF/wtf/FileSystem.h:87
> +enum class FileAccessPermission {

: bool

> Source/WTF/wtf/posix/FileSystemPOSIX.cpp:96
>	   platformFlag |= O_EVTONLY;

Please also change this to a switch.

> Source/WTF/wtf/win/FileSystemWin.cpp:638
> +    default:
> +	   ASSERT_NOT_REACHED();

Again, please remove the default.

> Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:96
> +    memcpy(buffer.data(), map, size);

Do we really want this memcpy here?  Doesn't that defeat the purpose of having
mapped memory?