[webkit-reviews] review granted: [Bug 207073] Regression(r248734) StorageAreaMap objects are getting leaked : [Attachment 389870] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 207073: Regression(r248734) StorageAreaMap objects are getting leaked
https://bugs.webkit.org/show_bug.cgi?id=207073

Attachment 389870: Patch

https://bugs.webkit.org/attachment.cgi?id=389870&action=review




--- Comment #19 from Darin Adler <darin at apple.com> ---
Comment on attachment 389870
  --> https://bugs.webkit.org/attachment.cgi?id=389870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389870&action=review

Looks great.

> Source/WebCore/storage/StorageNamespaceProvider.h:62
> +    WEBCORE_EXPORT StorageNamespace& localStorageNamespace(PAL::SessionID);

Isn’t there a separate export macro just for internals? If so, we should
ideally use it here. Or if the distinction doesn’t matter we should eventually
get rid of it and just always use WEBCORE_EXPORT.

> LayoutTests/TestExpectations:830
> +# This test is only releveant for WebKit2.

Spelling error: "relevant". Some day I hope we can retire the term "WebKit2"
and move more fully to "modern" and "legacy".