[webkit-reviews] review granted: [Bug 207276] Update sandbox to allow communication with dnssd service : [Attachment 389827] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 12:59:01 PST 2020


Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 207276: Update sandbox to allow communication with dnssd service
https://bugs.webkit.org/show_bug.cgi?id=207276

Attachment 389827: Patch

https://bugs.webkit.org/attachment.cgi?id=389827&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 389827
  --> https://bugs.webkit.org/attachment.cgi?id=389827
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389827&action=review

R=me.

>>>
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:95
>>> +		 (allow mach-lookup (global-name "com.apple.dnssd.service"))))
;; <rdar://problem/55562091>
>> 
>> Should this be outside 'if gizmo?'?
> 
> It is in the 'else' of the 'if gizmo?' clause, so it's correct.

Ah, I see!


More information about the webkit-reviews mailing list