[webkit-reviews] review granted: [Bug 207275] Adopt MTOverrideShouldPlayHDRVideo() : [Attachment 389828] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 207275: Adopt MTOverrideShouldPlayHDRVideo()
https://bugs.webkit.org/show_bug.cgi?id=207275

Attachment 389828: Patch

https://bugs.webkit.org/attachment.cgi?id=389828&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 389828
  --> https://bugs.webkit.org/attachment.cgi?id=389828
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389828&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:936
> +    WebCore::setScreenProperties(properties);

The namespace shouldn't be necessary

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:945
> +	   WebCore::setShouldOverrideScreenSupportsHighDynamicRange(false,
false);

Ditto

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:952
> +    WebCore::setShouldOverrideScreenSupportsHighDynamicRange(true,
allPagesAreOnHDRScreens);

Ditto