[webkit-reviews] review requested: [Bug 207176] [OpenSSL] Implement WebCrypto APIs for AES-CBC, AES-CFB and AES-GCM : [Attachment 389788] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 02:41:53 PST 2020


Tomoki Imai <tomoki.imai at sony.com> has asked  for review:
Bug 207176: [OpenSSL] Implement WebCrypto APIs for AES-CBC, AES-CFB and AES-GCM
https://bugs.webkit.org/show_bug.cgi?id=207176

Attachment 389788: patch

https://bugs.webkit.org/attachment.cgi?id=389788&action=review




--- Comment #13 from Tomoki Imai <tomoki.imai at sony.com> ---
Created attachment 389788

  --> https://bugs.webkit.org/attachment.cgi?id=389788&action=review

patch

- Drop AES-CTR support.
- Replace "Finalise" with "Finalize"
- Fix some capitalization in comments.

By this patch, we addressed all the reviewed points in comment 3 - comment 7.


More information about the webkit-reviews mailing list