[webkit-reviews] review denied: [Bug 207244] REGRESSION(r254534): 1-3% regression on PLT : [Attachment 389758] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 207244: REGRESSION(r254534): 1-3% regression on PLT
https://bugs.webkit.org/show_bug.cgi?id=207244

Attachment 389758: Patch

https://bugs.webkit.org/attachment.cgi?id=389758&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 389758
  --> https://bugs.webkit.org/attachment.cgi?id=389758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389758&action=review

> Source/WebCore/ChangeLog:10
> +	   This is a partial revert of the regressing patch.

Please clarify that it's a full behavior revert, and a partial code revert.

> Source/WTF/wtf/PlatformHave.h:466
>  #define HAVE_CTFONTTRANSFORMGLYPHSWITHLANGUAGE 1

Maybe just #define to 0

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:48
> +	   paragraphStyle = adoptCF(CTParagraphStyleCreate(nullptr, 0));

Here adoptCF makes a temporary RetainPtr but it's then destroyed, so
paragraphStyle is left with a pointer to a deleted object.