[webkit-reviews] review denied: [Bug 207207] Fix race condition for WKWebView._negotiatedLegacyTLS when loading main resource : [Attachment 389734] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 207207: Fix race condition for WKWebView._negotiatedLegacyTLS when loading
main resource
https://bugs.webkit.org/show_bug.cgi?id=207207

Attachment 389734: Patch

https://bugs.webkit.org/attachment.cgi?id=389734&action=review




--- Comment #12 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 389734
  --> https://bugs.webkit.org/attachment.cgi?id=389734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389734&action=review

> Source/WebKit/ChangeLog:18
> +	   In order to maintain binary compatibility with existing disk caches,
I bundle two booleans together
> +	   when encoding.  This results in existing disk caches saying they
loaded nothing over legacy TLS,
> +	   which is somewhat correct because TLS 1.0 and 1.1 were not
deprecated when the resources were fetched.
> +	   Going forward, the bit will be set and the disk cache entries will
store whether they were loaded
> +	   over legacy TLS.

This isn't true in the newest patch.

Also, this is a separate change that is unrelated to the race condition you're
trying to fix. Can you make two separate patches? The choice for what's right
for the disk cache probably deserves some discussion, and the fix for the race
condition need not wait on that discussion.