[webkit-reviews] review denied: [Bug 207080] WebCore links to stale libANGLE.dylib instead of libANGLE.a : [Attachment 389591] Rename libANGLE.a to libANGLE-static.a

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has denied James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 207080: WebCore links to stale libANGLE.dylib instead of libANGLE.a
https://bugs.webkit.org/show_bug.cgi?id=207080

Attachment 389591: Rename libANGLE.a to libANGLE-static.a

https://bugs.webkit.org/attachment.cgi?id=389591&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 389591
  --> https://bugs.webkit.org/attachment.cgi?id=389591
Rename libANGLE.a to libANGLE-static.a

Unfortunately we can't do this, because the Apple build system will freak out
that we're no longer producing a libANGLE.a, even if we update WebCore at the
same time because everything is built in isolation. This is why the change to a
dylib was eventually called libANGLE-shared.dylib - I learnt the hard way. 

The good news is that the bots with the stale file have been cleared, and if it
happens again we know what to do.

We'll also move to libANGLE-shared.dylib soon.