[webkit-reviews] review granted: [Bug 207173] Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide : [Attachment 389631] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 207173: Defer ending AppSSO sheets til NSWindowDidDeminiaturize or
NSApplicationDidUnhide
https://bugs.webkit.org/show_bug.cgi?id=207173

Attachment 389631: Patch

https://bugs.webkit.org/attachment.cgi?id=389631&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 389631
  --> https://bugs.webkit.org/attachment.cgi?id=389631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389631&action=review

r=me

> Source/WebKit/ChangeLog:14
> +	   or NSApplicationDidUnhide is received.

What happens if the application is exited? Is everything cleaned up properly
with these deferred observers? (I assume so).