[webkit-reviews] review granted: [Bug 207208] [GStreamer] Client-side video rendering doesn't fallback to internal compositing : [Attachment 389674] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 207208: [GStreamer] Client-side video rendering doesn't fallback to
internal compositing
https://bugs.webkit.org/show_bug.cgi?id=207208

Attachment 389674: Patch

https://bugs.webkit.org/attachment.cgi?id=389674&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 389674
  --> https://bugs.webkit.org/attachment.cgi?id=389674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389674&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3172
> +    auto internalCompositingOperation =
[this](TextureMapperPlatformLayerProxy& proxy,
std::unique_ptr<GstVideoFrameHolder> frameHolder) {

You're moving the frameholder when calling this, so I guess you should make
this && as well.

Anyway, why do you create a lambda instead of a method considering that we are
only capturing this?