[webkit-reviews] review granted: [Bug 207192] Check for callback being null in Notification.requestPermission : [Attachment 389644] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 4 08:07:59 PST 2020


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 207192: Check for callback being null in Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=207192

Attachment 389644: Patch

https://bugs.webkit.org/attachment.cgi?id=389644&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 389644
  --> https://bugs.webkit.org/attachment.cgi?id=389644
Patch

r=me. Not in this patch but it would be good to update this method to return a
Promise as well.


More information about the webkit-reviews mailing list