[webkit-reviews] review granted: [Bug 206730] [EME][GStreamer] Introduce CDMProxy : [Attachment 389648] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 206730: [EME][GStreamer] Introduce CDMProxy
https://bugs.webkit.org/show_bug.cgi?id=206730

Attachment 389648: Patch

https://bugs.webkit.org/attachment.cgi?id=389648&action=review




--- Comment #23 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 389648
  --> https://bugs.webkit.org/attachment.cgi?id=389648
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389648&action=review

> Source/WebCore/platform/encryptedmedia/CDMProxy.cpp:76
> +	   // NOTE: Do we care that we will not append a key in other if it
matches a key ID
> +	   // in the keystore and has different data. Should we overwrite?
Which is "newer"?
> +	   // Don't think we need this extra complexity.

I wonder if we should ASSERT here just in case?

> Source/WebCore/platform/encryptedmedia/CDMProxy.h:174
> +    KeyStore m_keyStore;

we have two key stores, wouldn't it be possible to have only one? Maybe a fixme
for a next iterations?

> Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h:144
> +	   const uint8_t* keyID;
> +	   size_t keyIDSizeInBytes;
> +
> +	   const uint8_t* iv;
> +	   size_t ivSizeInBytes;
> +
> +	   uint8_t* encryptedBuffer;
> +	   size_t encryptedBufferSizeInBytes;

FIXME, encapsulate these in non-copied structures.

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorG
Streamer.cpp:275
> +static CDMProxy*
requestCDMProxyFromGstContext(WebKitMediaCommonEncryptionDecrypt* self)

Nit, I think we are not requesting, more like getting, specially according to
the long comment (yes, I wrote that myself)