[webkit-reviews] review granted: [Bug 207079] Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy : [Attachment 389467] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 3 19:10:12 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 207079: Pass a hint from the extension to
decidePolicyForSOAuthorizationLoadWithCurrentPolicy
https://bugs.webkit.org/show_bug.cgi?id=207079

Attachment 389467: Patch

https://bugs.webkit.org/attachment.cgi?id=389467&action=review




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 389467
  --> https://bugs.webkit.org/attachment.cgi?id=389467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389467&action=review

> Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:172
> +    // FIXME: <rdar://problem/48909336> Replace the below with AppSSO
constants.

It might be nice to resolve this one, soon!


More information about the webkit-reviews mailing list