[webkit-reviews] review granted: [Bug 207172] [JSC] Use PackedCellPtr for VariableEnvironment : [Attachment 389608] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 207172: [JSC] Use PackedCellPtr for VariableEnvironment
https://bugs.webkit.org/show_bug.cgi?id=207172

Attachment 389608: Patch

https://bugs.webkit.org/attachment.cgi?id=389608&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 389608
  --> https://bugs.webkit.org/attachment.cgi?id=389608
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389608&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   * runtime/CachedTypes.cpp:
> +	   (JSC::CachedRefPtr::encode):
> +	   (JSC::CachedRefPtr::decode const):

Your ChangeLog and title doesn't seem to include changes in CachedTypes.  Is
this intended to be part of this patch?  If so, can you add a small blurb in
the ChangeLog or update the title?