[webkit-reviews] review granted: [Bug 207058] [iPad] Videos on nhl.com can't be scrubbed when loaded with desktop UA. : [Attachment 389518] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 207058: [iPad] Videos on nhl.com can't be scrubbed when loaded with desktop
UA.
https://bugs.webkit.org/show_bug.cgi?id=207058

Attachment 389518: Patch

https://bugs.webkit.org/attachment.cgi?id=389518&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 389518
  --> https://bugs.webkit.org/attachment.cgi?id=389518
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389518&action=review

> Source/WebCore/page/Quirks.cpp:295
> +    if (m_shouldDispatchSimulatedMouseEventsQuirk)
> +	   return m_shouldDispatchSimulatedMouseEventsQuirk.value();

I suggest merging this with the code below.

> Source/WebCore/page/Quirks.cpp:353
> +    m_shouldDispatchSimulatedMouseEventsQuirk = doShouldDispatchChecks();
> +    return m_shouldDispatchSimulatedMouseEventsQuirk.value();

I suggest writing it like this:

    if (!m_shouldDispatchSimulatedMouseEventsQuirk)
	m_shouldDispatchSimulatedMouseEventsQuirk = doShouldDispatchChecks();
    return *m_shouldDispatchSimulatedMouseEventsQuirk;

I don’t think we need the second return statement above.