[webkit-reviews] review granted: [Bug 206958] [ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure : [Attachment 389504] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 07:15:00 PST 2020
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206958: [ macOS wk2 ]
http/tests/media/media-stream/get-display-media-prompt.html is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206958
Attachment 389504: Patch
https://bugs.webkit.org/attachment.cgi?id=389504&action=review
--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 389504
--> https://bugs.webkit.org/attachment.cgi?id=389504
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=389504&action=review
> Source/WebCore/ChangeLog:11
> + For that reason, we were storing a pointer to the gesture event and
resetting in case the current gesture event was equal to the stored pointer.
> + Instead, store a WeakPtr which ensures that if the previous event is
destroyed, the weak pointer will be null and so will not have the same value as
the new gesture event.
Nit: these lines are really long and should be wrapped.
More information about the webkit-reviews
mailing list