[webkit-reviews] review granted: [Bug 206862] Replace RGBA32 typedef with a class to improve type safety : [Attachment 389460] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 206862: Replace RGBA32 typedef with a class to improve type safety
https://bugs.webkit.org/show_bug.cgi?id=206862

Attachment 389460: Patch

https://bugs.webkit.org/attachment.cgi?id=389460&action=review




--- Comment #9 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 389460
  --> https://bugs.webkit.org/attachment.cgi?id=389460
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389460&action=review

> Source/WebCore/page/cocoa/ResourceUsageOverlayCocoa.mm:131
> +    HistoricMemoryCategoryInfo(unsigned category, unsigned rgba, String
name, bool subcategory = false)

I think uint32_t would be slightly better here.