[webkit-reviews] review granted: [Bug 206954] [curl] PublicSuffixCurl should skip leading dots : [Attachment 389168] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 2 18:52:30 PST 2020
Fujii Hironori <Hironori.Fujii at sony.com> has granted Christopher Reid
<chris.reid at sony.com>'s request for review:
Bug 206954: [curl] PublicSuffixCurl should skip leading dots
https://bugs.webkit.org/show_bug.cgi?id=206954
Attachment 389168: patch
https://bugs.webkit.org/attachment.cgi?id=389168&action=review
--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 389168
--> https://bugs.webkit.org/attachment.cgi?id=389168
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=389168&action=review
> Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:73
> + while (domainUTF8.data()[position] == '.')
Do you really need to skip multiple leading dots?
I know you copied the implementation of PublicSuffixSoup.cpp.
More information about the webkit-reviews
mailing list