[webkit-reviews] review granted: [Bug 207071] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html : [Attachment 389480] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 207071: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(),
key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071

Attachment 389480: Patch

https://bugs.webkit.org/attachment.cgi?id=389480&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 389480
  --> https://bugs.webkit.org/attachment.cgi?id=389480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389480&action=review

> Source/WebCore/ChangeLog:10
> +	   We cannot add CSSPropertyInvalid to a HashSet<CSSPropertyID>,
because it triggers an ASSERT, and also we shouldn't
> +	   because we wouldn't know how to animate that CSS property.

Can you write a test that would have reproducibly crashed? How did we get an
invalid property?