[webkit-reviews] review granted: [Bug 220135] [LFC][Integration] Use the pre-computed geometries for the inline level boxes : [Attachment 416737] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 220135: [LFC][Integration] Use the pre-computed geometries for the inline
level boxes
https://bugs.webkit.org/show_bug.cgi?id=220135

Attachment 416737: Patch

https://bugs.webkit.org/attachment.cgi?id=416737&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 416737
  --> https://bugs.webkit.org/attachment.cgi?id=416737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416737&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.h:70
> +    // For integration only.
> +    void collectInlineContentIfNeeded();
> +    void lineLayout(InlineItems&, LineBuilder::InlineItemRange, const
ConstraintsForInFlowContent&);

Saying that these are "intergration only" is bit misleading since they are used
internally in any case. They are just public for integration.

Maybe these could stay private and there could be public
'lineLayoutForIntergration' or similar that calls them?