[webkit-reviews] review granted: [Bug 220126] [GPU Process]: Don't call flushDrawingContext() in the middle of recording drawing commands : [Attachment 416720] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 220126: [GPU Process]: Don't call flushDrawingContext() in the middle of
recording drawing commands
https://bugs.webkit.org/show_bug.cgi?id=220126

Attachment 416720: Patch

https://bugs.webkit.org/attachment.cgi?id=416720&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 416720
  --> https://bugs.webkit.org/attachment.cgi?id=416720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416720&action=review

>> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:-185
>> -	imageBuffer.flushDrawingContext();
> 
> Just to confirm — we don't need to call CGContextFlush for the previous
canvas's remote image buffer either?

CG should take care of flushing when drawing one IOSurface-based CGContext into
another.