[webkit-reviews] review granted: [Bug 192314] [WinCairo] Enable WebGL 2 : [Attachment 416704] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 23 10:05:58 PST 2020
Kenneth Russell <kbr at google.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192314: [WinCairo] Enable WebGL 2
https://bugs.webkit.org/show_bug.cgi?id=192314
Attachment 416704: Patch
https://bugs.webkit.org/attachment.cgi?id=416704&action=review
--- Comment #21 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 416704
--> https://bugs.webkit.org/attachment.cgi?id=416704
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416704&action=review
Hooray! Glad this is working! r+
> Source/WebCore/platform/graphics/texmap/ANGLEContext.cpp:133
> + contextAttributes.append(EGL_FALSE);
Per your comment on https://bugs.webkit.org/show_bug.cgi?id=220098 - if you can
find a way to refactor this ANGLE EGL context initialization code so it can be
shared among all ports, that would be very welcome.
More information about the webkit-reviews
mailing list