[webkit-reviews] review granted: [Bug 220096] Remove non-inclusive language from tests in http/tests/xmlhttprequest : [Attachment 416689] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 22 15:32:59 PST 2020
Alexey Proskuryakov <ap at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 220096: Remove non-inclusive language from tests in
http/tests/xmlhttprequest
https://bugs.webkit.org/show_bug.cgi?id=220096
Attachment 416689: Patch
https://bugs.webkit.org/attachment.cgi?id=416689&action=review
--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 416689
--> https://bugs.webkit.org/attachment.cgi?id=416689
Patch
I see the problem - cgi files need to have the Unix executable bit set, and
they do not when testing the patch in EWS.
Applying the patch locally to an svn checkout with svn-apply, I see the
executable bit preserved on rename, so it must be a webkit-patch limitation
when dealing with git-svn.
Please land this manually from a pure svn checkout, or I can land it for you.
More information about the webkit-reviews
mailing list