[webkit-reviews] review granted: [Bug 219741] Support aspect-ratio on positioned elements : [Attachment 416038] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 219741: Support aspect-ratio on positioned elements
https://bugs.webkit.org/show_bug.cgi?id=219741

Attachment 416038: Patch

https://bugs.webkit.org/attachment.cgi?id=416038&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 416038
  --> https://bugs.webkit.org/attachment.cgi?id=416038
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416038&action=review

> Source/WebCore/rendering/RenderBox.cpp:5011
> +    if (style().width().isAuto() && style().height().isAuto() &&
!style().top().isAuto() && !style().bottom().isAuto() &&
(style().left().isAuto() || style().right().isAuto()))

Maybe all these could become a helper on RenderStyle.

> Source/WebCore/rendering/RenderBox.cpp:5024
> +    LayoutUnit containerWidthIninlineDirection = std::max<LayoutUnit>(0,
containingBlockLogicalWidthForContentInFragment(fragment));

containerWidthInIInlineDirection