[webkit-reviews] review granted: [Bug 219822] REGRESSION(r270612) [GStreamer][MSE] Some play/seek related failures : [Attachment 416660] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 219822: REGRESSION(r270612) [GStreamer][MSE] Some play/seek related
failures
https://bugs.webkit.org/show_bug.cgi?id=219822

Attachment 416660: Patch

https://bugs.webkit.org/attachment.cgi?id=416660&action=review




--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 416660
  --> https://bugs.webkit.org/attachment.cgi?id=416660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416660&action=review

r+ conditional to what Alicia thinks of this

>
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
:196
> +    SourceBufferPrivate::appendCompleted(true, m_mediaSource ?
m_mediaSource->isEnded() : true);

Is it necessary to prepend the superclass name? Method is protected and should
be available in the subclass, right?

>
Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp
:201
> +    SourceBufferPrivate::appendCompleted(false, m_mediaSource ?
m_mediaSource->isEnded() : true);

Ditto.