[webkit-reviews] review granted: [Bug 219649] [iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout correctly upon exit : [Attachment 415683] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 219649: [iOS] Entering fullscreen from less-than-fullscreen WKWebView does
not layout correctly upon exit
https://bugs.webkit.org/show_bug.cgi?id=219649

Attachment 415683: Patch

https://bugs.webkit.org/attachment.cgi?id=415683&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 415683
  --> https://bugs.webkit.org/attachment.cgi?id=415683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415683&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:246
> + at property (nonatomic, readonly) BOOL _hasOverridenLayoutParameters;

Ok as is. Consider overriding instead of overridden. If going to keep
overridden then consider fixing spelling.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:159
> +	       _savedMinimumLayoutSizeOverride =
webView._minimumLayoutSizeOverride;

Ok as is. Consider rename using overriding