[webkit-reviews] review granted: [Bug 220047] Simplify CARingBuffer usage with SharedMemory storage : [Attachment 416589] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 220047: Simplify CARingBuffer usage with SharedMemory storage
https://bugs.webkit.org/show_bug.cgi?id=220047

Attachment 416589: Patch

https://bugs.webkit.org/attachment.cgi?id=416589&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 416589
  --> https://bugs.webkit.org/attachment.cgi?id=416589
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416589&action=review

r=me

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:40
> +void* ReadOnlySharedRingBufferStorage::data()

const void*?

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:45
> +auto ReadOnlySharedRingBufferStorage::sharedFrameBounds() const ->
FrameBounds*

const FrameBounds*?