[webkit-reviews] review granted: [Bug 220000] [WinCairo][WebGL] webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug builds : [Attachment 416499] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 18 14:21:36 PST 2020


Kenneth Russell <kbr at google.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 220000: [WinCairo][WebGL]
webgl/1.0.3/conformance/misc/uninitialized-test.html is failing only for Debug
builds
https://bugs.webkit.org/show_bug.cgi?id=220000

Attachment 416499: Patch

https://bugs.webkit.org/attachment.cgi?id=416499&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 416499
  --> https://bugs.webkit.org/attachment.cgi?id=416499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416499&action=review

Good find; looks good to me. r+

> Source/WebCore/platform/graphics/win/PlatformDisplayWin.cpp:36
> +    EGLint attributs[] = {

Typo: attributes


More information about the webkit-reviews mailing list