[webkit-reviews] review granted: [Bug 220019] Login flows on sites with ITP quirks no longer work with ITP disabled : [Attachment 416529] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 220019: Login flows on sites with ITP quirks no longer work with ITP
disabled
https://bugs.webkit.org/show_bug.cgi?id=220019

Attachment 416529: Patch

https://bugs.webkit.org/attachment.cgi?id=416529&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 416529
  --> https://bugs.webkit.org/attachment.cgi?id=416529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416529&action=review

> Source/WebCore/ChangeLog:14
> +	   No new tests, this will fix login flows on sites with ITP quirks
when
> +	   ITP is turned off. I confirmed these cases manually.

Disappointing there’s no way to test this. A test has value even in a simple
case like this, so if you do think of a way to validate it, that would be
welcome.