[webkit-reviews] review granted: [Bug 220003] Gate all of the code associated with app highlights : [Attachment 416491] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 17 19:43:00 PST 2020
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 220003: Gate all of the code associated with app highlights
https://bugs.webkit.org/show_bug.cgi?id=220003
Attachment 416491: Patch
https://bugs.webkit.org/attachment.cgi?id=416491&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 416491
--> https://bugs.webkit.org/attachment.cgi?id=416491
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416491&action=review
> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:57
> humanReadableDescription: "Enable persistant highlights for apps"
While here, please “persistent”
> Source/WebCore/rendering/RenderTheme.h:165
> +#if ENABLE(APP_HIGHLIGHTS)
Definitely recommend moving this up a line
More information about the webkit-reviews
mailing list