[webkit-reviews] review granted: [Bug 219986] Fix "Open with Preview" menu item in PDF context menus on Big Sur : [Attachment 416444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 12:34:45 PST 2020

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 219986: Fix "Open with Preview" menu item in PDF context menus on Big Sur

Attachment 416444: Patch


--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 416444
  --> https://bugs.webkit.org/attachment.cgi?id=416444

View in context: https://bugs.webkit.org/attachment.cgi?id=416444&action=review


Can an API test use a fake mouse event to test this in at least a simple case?

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:2327
> +	   if ([NSStringFromSelector(item.action)
> +	       openInPreviewIndex = i;

I think this means that a rename inside the PDFLayerController project would
reintroduce this bug.

Could you file a request for explicit support for getting this item index?

More information about the webkit-reviews mailing list