[webkit-reviews] review granted: [Bug 219900] Still can't login to my.playstation.com : [Attachment 416437] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 219900: Still can't login to my.playstation.com
https://bugs.webkit.org/show_bug.cgi?id=219900

Attachment 416437: Patch

https://bugs.webkit.org/attachment.cgi?id=416437&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 416437
  --> https://bugs.webkit.org/attachment.cgi?id=416437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416437&action=review

> Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm:67
> +#if PLATFORM(MAC)
> +    NSString *alertTitle = [NSString stringWithFormat:WEB_UI_NSSTRING(@"Do
you want to allow â%@â and â%@â to use cookies and website data while browsing
â%@â?", @"Message for requesting cross-site cookie and website data access."),
firstRequestingDomain.get(), secondRequestingDomain.get(),
currentDomain.get()];
> +#else
> +    NSString *alertTitle = [NSString
stringWithFormat:WEB_UI_NSSTRING(@"Allow â%@â and â%@â to use cookies and
website data while browsing â%@â?", @"Message for requesting cross-site cookie
and website data access."), firstRequestingDomain.get(),
secondRequestingDomain.get(), currentDomain.get()];
> +#endif
> +
> +    NSString *informativeText = [NSString
stringWithFormat:WEB_UI_NSSTRING(@"This will allow â%@â and â%@â to track your
activity.", @"Informative text for requesting cross-site cookie and website
data access."), firstRequestingDomain.get(), secondRequestingDomain.get()];

I’m a bit puzzled about the use, here and elsewhere, of +[NSString
stringWithFormat:] instead of +[NSString localizedStringWithFormat:] since
these are uses of formatting for localization. It’s possible that this doesn’t
matter in the case where the only format used is %@.

I’m also sort of wishing that a little bit more of this code was
cross-platform.