[webkit-reviews] review granted: [Bug 219510] Web Inspector: REGRESSION(r266467): viewing a WebSocket created before Web Inspector was opened doesn't show any message frames : [Attachment 416424] Patch v1.2 - Youenn review notes

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Patrick Angle
<pangle at apple.com>'s request for review:
Bug 219510: Web Inspector: REGRESSION(r266467): viewing a WebSocket created
before Web Inspector was opened doesn't show any message frames
https://bugs.webkit.org/show_bug.cgi?id=219510

Attachment 416424: Patch v1.2 - Youenn review notes

https://bugs.webkit.org/attachment.cgi?id=416424&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 416424
  --> https://bugs.webkit.org/attachment.cgi?id=416424
Patch v1.2 - Youenn review notes

LGTM.
It would be good to check the test is passing with the new code path.
This can be done locally by changing
WKPreferencesSetIsNSURLSessionWebSocketEnabled(preferences, false) to
WKPreferencesSetIsNSURLSessionWebSocketEnabled(preferences, true) in
TestController.cpp than running the new test with WTR.
If it does not pass, let me know and I'll look at the issue.