[webkit-reviews] review granted: [Bug 219961] [Cocoa] WebM format reader doesn't work with a url in a <source> element : [Attachment 416417] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 07:21:13 PST 2020


Andy Estes <aestes at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 219961: [Cocoa] WebM format reader doesn't work with a url in a <source>
element
https://bugs.webkit.org/show_bug.cgi?id=219961

Attachment 416417: Patch

https://bugs.webkit.org/attachment.cgi?id=416417&action=review




--- Comment #6 from Andy Estes <aestes at apple.com> ---
Comment on attachment 416417
  --> https://bugs.webkit.org/attachment.cgi?id=416417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416417&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:484
> +    if (!os_variant_allows_internal_security_policies("com.apple.WebKit"))

Since the value won't change at runtime, can you break this out into a helper
function that caches the result of
os_variant_allows_internal_security_policies() in a static bool? This was my
mistake from earlier, but maybe you can fix it while you're here :)


More information about the webkit-reviews mailing list